-
-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐝 (staging) sophia #3639
Closed
Closed
🐝 (staging) sophia #3639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quick links (staging server):
Login:
SVG tester:Number of differences (default views): 0 ✅ Edited: 2024-09-17 22:40:49 UTC |
sophiamersmann
force-pushed
the
sophia
branch
5 times, most recently
from
September 17, 2024 22:32
427432c
to
6fbf6f0
Compare
sophiamersmann
force-pushed
the
sophia
branch
from
October 22, 2024 09:25
6fbf6f0
to
526aca2
Compare
sophiamersmann
force-pushed
the
sophia
branch
from
November 20, 2024 17:00
526aca2
to
ab6f28d
Compare
sophiamersmann
force-pushed
the
sophia
branch
3 times, most recently
from
December 19, 2024 15:18
3c82085
to
5c982e4
Compare
✨ persist alt text between image revisions
Update SiteNavigation.tsx
Update SiteNavigation.tsx
One test in the Marimekko test suite is flaky and (sometimes) fails. It seems to be a rounding issue. Instead of rounding the values ourselves, I use jest's `toBeCloseTo` that compares floating point values allowing for imprecision.
* ✨ (discrete bar) hide horizontal axis * 🔨 remove relative mode from discrete bar chart configs * 🤖 style: prettify code
✨ "Archive" label in dataset, link to Dataset preview in Wizard
* init * init * 🤖 style: prettify code
* change db table type * 🤖 style: prettify code
* migration * 🤖 style: prettify code * add annotation
* fix all migrations * 🤖 style: prettify code * create if not exists
Since React 17 we no longer need to import React for JSX transforms. Running this codemod: * Removes all unused React imports as a result of upgrading to the new JSX transform. * Changes all default React imports (i.e. import React from "react") to destructured named imports (ex. import { useState } from "react") which is the preferred style going into the future. These cannot be separated, even though we now only needed to remove the unused imports.
Fast Refresh is a feature that lets you edit React components in a running application without losing their state. It is similar to an old feature known as "hot reloading", but Fast Refresh is more reliable and officially supported by React. Vite already supports Fast Refresh, but it works only under specific conditions. This ESlint plugin helps us write components in a way that ensures they can be reloaded using Fast Refresh. We don't enable it for directories containing mostly class components, since it doesn't work for them. As part of this change I fixed the linter errors by refactoring the code, which means now many more components will be working with Fast Refresh, speeding up the local development. https://github.com/ArnaudBarre/eslint-plugin-react-refresh https://github.com/vitejs/vite-plugin-react/tree/main/packages/plugin-react#consistent-components-exports
Several files had the .tsx extension despite not containing any JSX.
- Show Subscribe instead of Donate button again - Remove call to action top banner
It should not be used anywhere.
... to get rid of a Node 22 deprecation warning
🐝 set row key on images table
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.