Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐝 (staging) sophia #3639

Closed
wants to merge 29 commits into from
Closed

🐝 (staging) sophia #3639

wants to merge 29 commits into from

Conversation

sophiamersmann
Copy link
Member

No description provided.

@owidbot
Copy link
Contributor

owidbot commented May 23, 2024

Quick links (staging server):

Site Admin Wizard

Login: ssh owid@staging-site-sophia

SVG tester:

Number of differences (default views): 0 ✅
Number of differences (all views): 0 ✅

Edited: 2024-09-17 22:40:49 UTC
Execution time: 1.20 seconds

ikesau and others added 16 commits January 8, 2025 11:42
✨ persist alt text between image revisions
One test in the Marimekko test suite is flaky and (sometimes) fails. It seems to be a rounding issue. Instead of rounding the values ourselves, I use jest's `toBeCloseTo` that compares floating point values allowing for imprecision.
* ✨ (discrete bar) hide horizontal axis

* 🔨 remove relative mode from discrete bar chart configs

* 🤖 style: prettify code
✨ "Archive" label in dataset, link to Dataset preview in Wizard
* change db table type

* 🤖 style: prettify code
lucasrodes and others added 13 commits January 8, 2025 11:42
* migration

* 🤖 style: prettify code

* add annotation
* fix all migrations

* 🤖 style: prettify code

* create if not exists
Since React 17 we no longer need to import React for JSX transforms.
Running this codemod:

* Removes all unused React imports as a result of upgrading to the new
  JSX transform.
* Changes all default React imports (i.e. import React from "react") to
  destructured named imports (ex. import { useState } from "react") which
  is the preferred style going into the future.

These cannot be separated, even though we now only needed to remove the
unused imports.
Fast Refresh is a feature that lets you edit React components in a
running application without losing their state. It is similar to an old
feature known as "hot reloading", but Fast Refresh is more reliable and
officially supported by React.

Vite already supports Fast Refresh, but it works only under specific
conditions. This ESlint plugin helps us write components in a way that
ensures they can be reloaded using Fast Refresh. We don't enable it for
directories containing mostly class components, since it doesn't work
for them.

As part of this change I fixed the linter errors by refactoring the
code, which means now many more components will be working with Fast
Refresh, speeding up the local development.

https://github.com/ArnaudBarre/eslint-plugin-react-refresh
https://github.com/vitejs/vite-plugin-react/tree/main/packages/plugin-react#consistent-components-exports
Several files had the .tsx extension despite not containing any JSX.
- Show Subscribe instead of Donate button again
- Remove call to action top banner
It should not be used anywhere.
... to get rid of a Node 22 deprecation warning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants